Add support for Soundcloud #186
Conversation
Everything before 39cfdd3, which created many conflicts.
Lots of cleanup remaining, and blocked on sampotts/plyr#189
| @@ -478,7 +481,7 @@ | |||
| // Removed call to arguments.callee (used explicit function name instead) | |||
| function _extend() { | |||
| // Get arguments | |||
| var objects = arguments; | |||
There was a problem hiding this comment.
I don't like tab indents either, but you need to revert these
|
Thanks @monicacheung, this is going to be a huge feature! I've mainly left comments on the plyr changes, I need to go through your changes in |
| /* | ||
| * Handle form submission. | ||
| */ | ||
| // TODO: Need to test this to make sure that nothing broke. |
There was a problem hiding this comment.
Yeah, I think it may be time to add some proper tests... #6. In the absence of that, we should create a QA checklist for manual tests until then - it can live on the wiki.
| that.setupPlyrToggle(); | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
We need to show an error for the else case
shakeelmohamed
force-pushed
the
plyr-rebased
branch
from
4d466d4 to
3e0b8e9
Compare
|
Ping me when you're ready to finish this up, here are the high level steps:
Bonus: let's try to retain every commit 💯 |
|
I'll clean up the branch since @monicacheung isn't able to work on this anymore. Then anyone can finish up what's left |
|
Closed in favor of #216, fixed many of the merge conflicts and reverted the plyr changes since ply has soundcloud support now |
Closes #2
You can enter a Soundcloud URL/trackID in the search bar or as a query string (?v=) in the URL and ZAP will play it.
Try these out in the ZAP search bar or ?v= in the URL:
There are changes to plyr.js in the directory bower_components/plyr to add support for Soundcloud to plyr. These are for test/debug until we send a PR to plyr.
Todo/Things that broke: